Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Wed, 12 Jul 2017 05:24:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13068269.1493679812000.224951.1499837040099@Atlassian.JIRA>
In-Reply-To: <JIRA.13068269.1493679812000@Atlassian.JIRA>
References: <JIRA.13068269.1493679812000@Atlassian.JIRA> <JIRA.13068269.1493679812115@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 12 Jul 2017 05:24:06 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083464#comment-16083464 ] 

ASF GitHub Bot commented on ZOOKEEPER-2770:
-------------------------------------------

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/307#discussion_r126866390
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -292,6 +293,8 @@ public void parseProperties(Properties zkProp)
                     }
                 } else if ((key.startsWith("server.") || key.startsWith("group") || key.startsWith("weight")) && zkProp.containsKey("dynamicConfigFile")) {
                     throw new ConfigException("parameter: " + key + " must be in a separate dynamic config file");
    +            } else if(key.equals("warn.responseTime")) {
    --- End diff --
    
    This is a new property, so it should be:
    
    * Documented - in particular mentions that this log can be disabled if set to -1. We don't want user to check code to figure out how to use this.
    * Add a test case to cover various code paths.
    
    Also, the name used here could be improved. I think something like request.warningthresholdms is more accurate. We already have fsync.warningthresholdms which in many ways has similar functionality of what's being added, so use that as a reference.


> ZooKeeper slow operation log
> ----------------------------
>
>                 Key: ZOOKEEPER-2770
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2770
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Karan Mehta
>         Attachments: ZOOKEEPER-2770.001.patch, ZOOKEEPER-2770.002.patch, ZOOKEEPER-2770.003.patch
>
>
> Log the client and request details if the server discovers, when finally processing the request, that the current time minus arrival time of the request is beyond a configured threshold. 
> Look at the HBase {{responseTooSlow}} feature for inspiration. 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)