Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: hanm <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-307-zookeeper@git.apache.org>
In-Reply-To: <git-pr-307-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log
Content-Type: text/plain
Message-Id: <20170712052328.3DA92E9438@git1-us-west.apache.org>
Date: Wed, 12 Jul 2017 05:23:28 +0000 (UTC)
archived-at: Wed, 12 Jul 2017 05:23:30 -0000

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/307#discussion_r126866390
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -292,6 +293,8 @@ public void parseProperties(Properties zkProp)
                     }
                 } else if ((key.startsWith("server.") || key.startsWith("group") || key.startsWith("weight")) && zkProp.containsKey("dynamicConfigFile")) {
                     throw new ConfigException("parameter: " + key + " must be in a separate dynamic config file");
    +            } else if(key.equals("warn.responseTime")) {
    --- End diff --
    
    This is a new property, so it should be:
    
    * Documented - in particular mentions that this log can be disabled if set to -1. We don't want user to check code to figure out how to use this.
    * Add a test case to cover various code paths.
    
    Also, the name used here could be improved. I think something like request.warningthresholdms is more accurate. We already have fsync.warningthresholdms which in many ways has similar functionality of what's being added, so use that as a reference.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---