Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: ivankelly <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-227-zookeeper@git.apache.org>
In-Reply-To: <git-pr-227-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper issue #227: ZOOKEEPER-2755 Allow to subclass ClientCnxnSocketNetty...
Content-Type: text/plain
Message-Id: <20170708064221.88D68E968F@git1-us-west.apache.org>
Date: Sat,  8 Jul 2017 06:42:21 +0000 (UTC)
archived-at: Sat, 08 Jul 2017 06:42:24 -0000

Github user ivankelly commented on the issue:

    https://github.com/apache/zookeeper/pull/227
  
    Is this for tests or for production use?
    
    > Using an ephemeral port may work but it makes trickier setting up things.
    How does it make things tricker? Each server you set up in the test setup just needs to expose a method to query which port it is listening. This is simplier than using a whole other transport, and ensures the same code paths will be used in the test as will be used in production.
    
    > Without opening ports you can run multiple parallel tests easily
    Opening ports doesn't have to be hard.
    
    > Opening a port can be seen as a security risk.
    Tests should not be run anywhere security is a concern.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---