zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Han (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2856) ZooKeeperSaslClient#respondToServer should log exception message of SaslException
Date Thu, 27 Jul 2017 00:27:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102522#comment-16102522
] 

Michael Han commented on ZOOKEEPER-2856:
----------------------------------------

Committed.
master: https://github.com/apache/zookeeper/commit/41b30a74ec8b33255e99d97a102de53d315c28b3
branch-3.5: https://github.com/apache/zookeeper/commit/f671a6a08258b911957cc2c3a9031a6d510ff8af
branch-3.4: https://github.com/apache/zookeeper/commit/90652669bece7bcde11e16df3f5722d80b3c5b31

> ZooKeeperSaslClient#respondToServer should log exception message of SaslException
> ---------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2856
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.10, 3.5.3
>            Reporter: Pan Yuxuan
>            Assignee: Pan Yuxuan
>            Priority: Minor
>             Fix For: 3.5.4, 3.6.0, 3.4.11
>
>         Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we sometimes
get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in ZooKeeperSaslClient#respondToServer
:
> {noformat}
>  catch (SaslException e) {
>                 LOG.error("SASL authentication failed using login context '" +
>                         this.getLoginContext() + "'.");
>                 saslState = SaslState.FAILED;
>                 gotLastPacket = true;
>   }
> {noformat}
> This error makes user confused without explicit exception message. So I think we can
add exception message to the log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message