zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2856) ZooKeeperSaslClient#respondToServer should log exception message of SaslException
Date Wed, 26 Jul 2017 07:13:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101260#comment-16101260
] 

Hadoop QA commented on ZOOKEEPER-2856:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require
tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/901//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/901//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/901//console

This message is automatically generated.

> ZooKeeperSaslClient#respondToServer should log exception message of SaslException
> ---------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2856
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.10, 3.5.3
>            Reporter: Pan Yuxuan
>            Assignee: Pan Yuxuan
>            Priority: Minor
>         Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we sometimes
get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in ZooKeeperSaslClient#respondToServer
:
> {noformat}
>  catch (SaslException e) {
>                 LOG.error("SASL authentication failed using login context '" +
>                         this.getLoginContext() + "'.");
>                 saslState = SaslState.FAILED;
>                 gotLastPacket = true;
>   }
> {noformat}
> This error makes user confused without explicit exception message. So I think we can
add exception message to the log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message