zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2856) ZooKeeperSaslClient#respondToServer should log exception message of SaslException
Date Wed, 26 Jul 2017 06:59:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101245#comment-16101245
] 

ASF GitHub Bot commented on ZOOKEEPER-2856:
-------------------------------------------

GitHub user pyx1990 opened a pull request:

    https://github.com/apache/zookeeper/pull/318

    ZOOKEEPER-2856 ZooKeeperSaslClient#respondToServer should log exception

    See https://issues.apache.org/jira/browse/ZOOKEEPER-2856 for details.
    
    When upstream like HBase call ZooKeeperSaslClient with security enabled, we sometimes
get error in HBase logs like:
    `SASL authentication failed using login context 'Client'.`
    This error occures when getting SaslException in ZooKeeperSaslClient#respondToServer :
    `catch (SaslException e) {`
                    `LOG.error("SASL authentication failed using login context '" +`
                           ` this.getLoginContext() + "'.");`
                    `saslState = SaslState.FAILED;`
                    `gotLastPacket = true;`
    `  }`
    This error makes user confused without explicit exception message. So I think we can add
exception message to the log.
    
    The patch uses  parameterized logging to add the exception message to the log.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pyx1990/zookeeper ZOOKEEPER-2856

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #318
    
----
commit 298a636acb2e1c7c09a0151ba6529aff101ea200
Author: panyuxuan <panyuxuan@cmss.chinamobile.com>
Date:   2017-07-26T06:47:29Z

    ZOOKEEPER-2856 ZooKeeperSaslClient#respondToServer should log exception
    message of SaslException

----


> ZooKeeperSaslClient#respondToServer should log exception message of SaslException
> ---------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2856
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.4.10, 3.5.3
>            Reporter: Pan Yuxuan
>            Assignee: Pan Yuxuan
>            Priority: Minor
>         Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we sometimes
get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in ZooKeeperSaslClient#respondToServer
:
> {noformat}
>  catch (SaslException e) {
>                 LOG.error("SASL authentication failed using login context '" +
>                         this.getLoginContext() + "'.");
>                 saslState = SaslState.FAILED;
>                 gotLastPacket = true;
>   }
> {noformat}
> This error makes user confused without explicit exception message. So I think we can
add exception message to the log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message