zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2842) optimize the finish() of Send/RecvWorker in QuorumCnxManager and remove testInitiateConnection() and formates some codes
Date Wed, 19 Jul 2017 05:09:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092584#comment-16092584
] 

ASF GitHub Bot commented on ZOOKEEPER-2842:
-------------------------------------------

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/308
  
    Nice comment. Please be patient, there are a lot of pull requests these days and many
of them have a higher priority (major feature, important bug fixes, and so on) and our limited
number of reviewers have other duties in their day job / life. That said, we definitely value
every contribution we receive, it just takes time to review all patches.
    
    For this pull request, please:
    * Update the JIRA with a detailed descriptions on motivations / impact of this change.
If it's optimization describe why this optimization is needed and what impact it has (an example:
the optimization could increase throughput of read/write mixed workload by 100x).
    
    * Put a title on the pull request, and more details on the descriptions of the pull request.


> optimize the finish() of Send/RecvWorker in QuorumCnxManager and remove testInitiateConnection()
and formates some codes
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2842
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2842
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum
>            Reporter: maoling
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message