zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2837) Add a special START_SERVER_JVMFLAGS option only for `start` command to distinguish JVMFLAGS and SERVER_JVMFLAGS
Date Tue, 04 Jul 2017 12:15:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073555#comment-16073555
] 

Hadoop QA commented on ZOOKEEPER-2837:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require
tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/857//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/857//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/857//console

This message is automatically generated.

> Add a special START_SERVER_JVMFLAGS option only for `start` command to distinguish JVMFLAGS
and SERVER_JVMFLAGS
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2837
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2837
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.3
>            Reporter: Benedict Jin
>            Assignee: Benedict Jin
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Add a special START_SERVER_JVMFLAGS option only for `start` command to distinguish JVMFLAGS
and SERVER_JVMFLAGS.
> If we use the normal way to add JVM options with `JVMFLAGS` in `conf/java.env`, then
it will effect almost all shell scripts under `bin` directory. Even if using `SERVER_JVMFLAGS`
will effect some commands like `zkServer.sh status`, include four-letters commands.
> For example, if the JVMFLAGS is 
> ```bash
> export JVMFLAGS="-Xms3G -Xmx3G -Xmn1G -XX:+AlwaysPreTouch -XX:CMSInitiatingOccupancyFraction=70
-XX:+UseParNewGC -XX:+UseConcMarkSweepGC -XX:+PrintGCDetails -XX:-PrintGCTimeStamps -Xloggc:/home/zookeeper/logs/zookeeper_`date
'+%Y%m%d%H%M%S'`.gc -XX:-UseGCLogFileRotation -XX:NumberOfGCLogFiles=10 -XX:GCLogFileSize=64M"
> ```
> then we will get too many GC log files due to using the `mntr` four-letters commands
in some monitor situation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message