zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2770) ZooKeeper slow operation log
Date Wed, 12 Jul 2017 05:28:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083468#comment-16083468
] 

ASF GitHub Bot commented on ZOOKEEPER-2770:
-------------------------------------------

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/307
  
    General comment: please add more description on the pull request on what's the motivation
of change and how it impacts performance / improve debugging etc. Or add those to the JIRA
and post a digest on the pull request. That will make others who does not have a lot of knowledge
on your use cases understand the motivation / impact of the change.
    
    Here is a good example w.r.t. pull request description: https://github.com/apache/zookeeper/pull/306,
for reference.


> ZooKeeper slow operation log
> ----------------------------
>
>                 Key: ZOOKEEPER-2770
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2770
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Karan Mehta
>         Attachments: ZOOKEEPER-2770.001.patch, ZOOKEEPER-2770.002.patch, ZOOKEEPER-2770.003.patch
>
>
> Log the client and request details if the server discovers, when finally processing the
request, that the current time minus arrival time of the request is beyond a configured threshold.

> Look at the HBase {{responseTooSlow}} feature for inspiration. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message