zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Han (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2491) C client build error in vs 2015
Date Thu, 27 Jul 2017 22:00:06 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103983#comment-16103983
] 

Michael Han commented on ZOOKEEPER-2491:
----------------------------------------

[~andschwa] 
There are two issues described in this JIRA actually - one is MSVC 15 finally implemented
C99 complaint snprintf so we don't need define that in header, this is fixed by your patch.
The other is how to deal with the fact that prior to MSVC 15 _snprintf does not add null terminator
at end of buffer, and this discussion somehow got involved with legal / license issue. I think
it's OK to close the JIRA, and let its scope only covers what the JIRA title describes. For
the _snprintf MSVC complaint issue, if it turns out to be an issue we can create a separate
JIRA to track it.

> C client build error in vs 2015 
> --------------------------------
>
>                 Key: ZOOKEEPER-2491
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.5.2
>         Environment: windows vs 2015
>            Reporter: spooky000
>            Assignee: Andrew Schwartzmeyer
>            Priority: Minor
>             Fix For: 3.5.4, 3.6.0
>
>         Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015  supports snprintf.
> #define snprintf _snprintf throw error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message