zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2490) infinitely connect on windows
Date Thu, 13 Jul 2017 18:18:02 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086141#comment-16086141
] 

Hadoop QA commented on ZOOKEEPER-2490:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require
tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/881//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/881//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/881//console

This message is automatically generated.

> infinitely connect on windows
> -----------------------------
>
>                 Key: ZOOKEEPER-2490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.5.2
>         Environment: Windows
>            Reporter: spooky000
>            Assignee: spooky000
>             Fix For: 3.5.4, 3.6.0
>
>         Attachments: ZOOKEEPER-2490.patch, ZOOKEEPER-2490.patch, ZOOKEEPER-2490.patch
>
>
> in addrvec_contains function
> this memcmp always return false on windows release build.
> for (i = 0; i < avec->count; i++)
> {
>     if(memcmp(&avec->data[i], addr, INET_ADDRSTRLEN) == 0)
>         return 1;
> }
> because..
> #define INET_ADDRSTRLEN  16 on linux.
> #define INET_ADDRSTRLEN  22 on windows.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message