zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet
Date Thu, 13 Jul 2017 03:59:01 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085152#comment-16085152
] 

ASF GitHub Bot commented on ZOOKEEPER-2355:
-------------------------------------------

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/304#discussion_r127123189
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/EphemeralNodeDeletionTest.java
---
    @@ -0,0 +1,219 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.zookeeper.server.quorum;
    +
    +import static org.apache.zookeeper.test.ClientBase.CONNECTION_TIMEOUT;
    +import static org.junit.Assert.assertNotNull;
    +import static org.junit.Assert.assertNull;
    +
    +import java.io.IOException;
    +import java.net.SocketTimeoutException;
    +
    +import org.apache.zookeeper.CreateMode;
    +import org.apache.zookeeper.PortAssignment;
    +import org.apache.zookeeper.ZooDefs.Ids;
    +import org.apache.zookeeper.ZooKeeper;
    +import org.apache.zookeeper.data.Stat;
    +import org.apache.zookeeper.server.persistence.FileTxnSnapLog;
    +import org.apache.zookeeper.server.quorum.QuorumPeer.ServerState;
    +import org.apache.zookeeper.test.ClientBase;
    +import org.apache.zookeeper.test.ClientBase.CountdownWatcher;
    +import org.junit.After;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import javax.security.sasl.SaslException;
    +
    +public class EphemeralNodeDeletionTest extends QuorumPeerTestBase {
    +    private static int SERVER_COUNT = 3;
    +    private MainThread[] mt = new MainThread[SERVER_COUNT];
    +
    +    /**
    +     * Test case for https://issues.apache.org/jira/browse/ZOOKEEPER-2355.
    +     * ZooKeeper ephemeral node is never deleted if follower fail while reading
    +     * the proposal packet.
    +     */
    +
    +    @Test(timeout = 120000)
    +    public void testEphemeralNodeDeletion() throws Exception {
    +        final int clientPorts[] = new int[SERVER_COUNT];
    +        StringBuilder sb = new StringBuilder();
    +        String server;
    +
    +        for (int i = 0; i < SERVER_COUNT; i++) {
    +            clientPorts[i] = PortAssignment.unique();
    +            server = "server." + i + "=127.0.0.1:" + PortAssignment.unique()
    +                    + ":" + PortAssignment.unique();
    +            sb.append(server + "\n");
    --- End diff --
    
    @asdf2014 Yes, I agree. Though I'd prefer doing this in a separate JIRA as a refactoring
task as it's used everywhere in tests. If you have time, you are more than welcome to file
a JIRA and do the refactoring work (btw, sorry for lagging on reviewing your refactoring patches,
we got many high priority JIRAs in the backlog that we want to get in first.).


> Ephemeral node is never deleted if follower fails while reading the proposal packet
> -----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2355
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum, server
>    Affects Versions: 3.4.8, 3.4.9, 3.4.10, 3.5.1, 3.5.2, 3.5.3
>            Reporter: Mohammad Arshad
>            Assignee: Mohammad Arshad
>            Priority: Critical
>         Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch, ZOOKEEPER-2355-03.patch,
ZOOKEEPER-2355-04.patch, ZOOKEEPER-2355-05.patch
>
>
> ZooKeeper ephemeral node is never deleted if follower fail while reading the proposal
packet
> The scenario is as follows:
> # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, start all, assume
A is leader, B and C are follower
> # Connect to any of the server and create ephemeral node /e1
> # Close the session, ephemeral node /e1 will go for deletion
> # While receiving delete proposal make Follower B to fail with {{SocketTimeoutException}}.
This we need to do to reproduce the scenario otherwise in production environment it happens
because of network fault.
> # Remove the fault, just check that faulted Follower is now connected with quorum
> # Connect to any of the server, create the same ephemeral node /e1, created is success.
> # Close the session,  ephemeral node /e1 will go for deletion
> # {color:red}/e1 is not deleted from the faulted Follower B, It should have been deleted
as it was again created with another session{color}
> # {color:green}/e1 is deleted from Leader A and other Follower C{color}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message