zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Zimmerman <jor...@jordanzimmerman.com>
Subject Re: Curator could use some help
Date Wed, 12 Jul 2017 19:06:07 GMT
We really appreciate the help Michael!

-JZ

> On Jul 12, 2017, at 12:18 AM, Michael Han <hanm@cloudera.com> wrote:
> 
> The spec is documented here, in case you need a reference.
> https://zookeeper.apache.org/doc/trunk/zookeeperReconfig.html
> 
> <digest>
> 
> A client port of a server is the port on which the server accepts client
> connection requests. Starting with 3.5.0 the *clientPort* and
> *clientPortAddress *configuration parameters should no longer be used.
> Instead, this information is now part of the server keyword specification,
> which becomes as follows:
> 
> server.<positive id> = <address1>:<port1>:<port2>[:role];[<client
port
> address>:]<client port>
> 
> The client port specification is to the right of the semicolon. The client
> port address is optional, and if not specified it defaults to "0.0.0.0". As
> usual, role is also optional, it can be *participant* or *observer*(
> *participant* by default).
> </digest>
> 
> I also made some comments on the pull request 205, which I think is a
> superset of pr 216.
> 
> I think Alex wrote the code so he is the ultimate expert on this, if you
> need a second eye.
> 
> On Tue, Jul 11, 2017 at 8:31 AM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
> 
>> Hi Folks,
>> 
>> Can anyone here with reconfig knowledge look at these two Curator PRs
>> please? The client address logic makes my head spin and I don't want to
>> make a mistake here:
>> 
>> https://github.com/apache/curator/pull/205/files <
>> https://github.com/apache/curator/pull/205/files>
>> 
>> https://github.com/apache/curator/pull/216/files <
>> https://github.com/apache/curator/pull/216/files>
>> 
>> We'd really appreciate it.
>> 
>> -Jordan
> 
> 
> 
> 
> -- 
> Cheers
> Michael.


Mime
View raw message