zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #312: ZOOKEEPER-1669: Operations to server will be ti...
Date Sun, 30 Jul 2017 05:50:48 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/312#discussion_r130233860
  
    --- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
    @@ -1001,25 +1010,14 @@ public String toString() {
         @Override
         public void close() {
             synchronized(factory.cnxns){
    --- End diff --
    
    The removeCnxn already synchronizes on the cnxns so this synchronization can be removed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message