zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #316: ZOOKEEPER-2829: Interface usability / compatibility im...
Date Thu, 27 Jul 2017 20:50:09 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/316
  
    Sounds good to me - my concern was that these empty packages should be removed but since
Hadoop and Hbase also has this "feature", and removing them default the purpose of the annotation,
I am OK with current approach. 
    
    I also verified the new javadoc with "ant javadoc", the newly added classes / APIs also
look good. Overall LGTM, good work @afine. Will merge soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message