zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #315: ZOOKEEPER-2577: Fix flaky testDuringLeaderSync ...
Date Thu, 27 Jul 2017 00:16:11 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/315#discussion_r129727799
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -1451,7 +1452,12 @@ public synchronized void restartLeaderElection(QuorumVerifier qvOLD,
QuorumVerif
         }
     
         public String getNextDynamicConfigFilename() {
    -        return configFilename + QuorumPeerConfig.nextDynamicConfigFileSuffix;
    +        if (configFilename != null) {
    --- End diff --
    
    @shralex Turns out pretty trivial to guarantee a real configFileName in this case - update
with one line change. Tested on apache jenkins the issue is fixed.
    
    Note we still have configFileName as null for some other tests (such as FLE tests) but
in those tests the intermediate reconfig file is not relevant so I'll just leave as they are.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message