zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #312: ZOOKEEPER-1669: Operations to server will be timed-out...
Date Thu, 20 Jul 2017 04:49:27 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/312
  
    @CheneySun some quick comments:
    * Can you please add more description to the pull request regarding how this patch fixes
the issue? You mentioned "just porting the work in [ZOOKEEPER-1347] ", but I don't see ZOOKEEPER-1347
has a patch nor it's committed to master.
    * There are some format only changes such as indentation changes - we prefer not mixing
format change with functional changes in a patch because it will make reviewer harder. But
for this case I think it's fine because old code was not well formatted and format only changes
are not too big to review.
    
    I'll take another pass on your patch later this week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message