zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #313: ZOOKEEPER-2841: ZooKeeper public include files leak po...
Date Wed, 19 Jul 2017 04:51:18 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/313
  
    @andschwa Thanks for update. I will review this later this week in detail. Regarding the
"flaky" test, AFAIK, this one is not particularly flaky (and in general, there are a lot less
flaky tests in C client tests comparing to Java tests). The pre-commit build is green though.
Did you observe fairly consistent failures for this `Zookeeper_simpleSystem::testAsyncWatcherAutoResetterminate`?
One thing we can try is to run this test with and without your patch and see if there are
any difference. Re integration tests - if you have time yeah please go ahead and try it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message