zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andschwa <...@git.apache.org>
Subject [GitHub] zookeeper issue #313: ZOOKEEPER-2841: ZooKeeper public include files leak po...
Date Tue, 18 Jul 2017 17:58:01 GMT
Github user andschwa commented on the issue:

    https://github.com/apache/zookeeper/pull/313
  
    @hanm this backports #306 to `branch-3.4`. I think I caught everything, but do give it
a review. The build changed a bit between 3.4 and 3.5, so I had to remove some files from
`CMakeLists.txt`, and I set the version to `3.4.10`. Then there were some fixes I had to do
a bit differently (moved the `#define random` into `zookeeper.c` since `addrvec.c` wasn't
created yet, reapply the changes I made to `zookeeper_interest` by hand, and one trivial merge
conflict in `recordio.h`).
    
    I build and ran the tests on Linux, all passing save:
    
    ```
    1: Zookeeper_simpleSystem::testAsyncWatcherAutoResetterminate called after throwing an
instance of 'CppUnit::Exception'
    1:   what():  equality assertion failed
    1: - Expected: -101
    1: - Actual  : -4
    ```
    
    which is odd. Is it a flaky test, or very machine dependent?
    
    I built on Windows, and it all compiled and linked successfully. If you want, I can integration
test it. I probably should anyway so I can move Mesos on Windows back to down to ZK 3.4 instead
of 3.5.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message