zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karanmehta93 <...@git.apache.org>
Subject [GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log
Date Mon, 17 Jul 2017 16:56:39 GMT
Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/307#discussion_r127762613
  
    --- Diff: src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
    @@ -460,11 +464,21 @@ public void processRequest(Request request) {
                 if (request.type == OpCode.closeSession) {
                     cnxn.sendCloseSession();
                 }
    +            checkLatency(request);
             } catch (IOException e) {
                 LOG.error("FIXMSG",e);
             }
         }
     
    +    private void checkLatency(Request request) {
    +        long requestWarnThresholdMs = QuorumPeerConfig.getRequestWarnResponseThresholdMs();
    --- End diff --
    
    I am thinking to cache the value of `requestWarnThresholdMs` inside the `FinalRequestProcessor.java`.
Is that a good idea?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message