zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivankelly <...@git.apache.org>
Subject [GitHub] zookeeper issue #227: ZOOKEEPER-2755 Allow to subclass ClientCnxnSocketNetty...
Date Mon, 17 Jul 2017 11:50:18 GMT
Github user ivankelly commented on the issue:

    https://github.com/apache/zookeeper/pull/227
  
    @eolivelli 
    Sorry for taking so long to respond, I was out of town.
    
    The commit message explains what the patch is doing, but not why. The reason I'm pushing
back a lot on this, is that I think it adds indirection and complexity, and I don't see what
the benefit is over simply binding to 0.
    
    The patch claims to abstract away the communication channel between server and client.
But this is a broken abstraction as there are many places where the application expects this
to be an IPv4 channel. To get around this you've created a static helper class, but internally
this either forces a cast to InetSocketAddress or provides a stub, which seems hacky.
    
    How are you using zookeeper in single node mode? Is it only as a metadata store for bk?
I'm reluctant to approve a patch that adds significant complexity without addressing a widely
desirable usecase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message