zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jainbhupendra24 <...@git.apache.org>
Subject [GitHub] zookeeper pull request #279: ZOOKEEPER-2804:Node creation fails with NPE if ...
Date Fri, 14 Jul 2017 12:39:05 GMT
Github user jainbhupendra24 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/279#discussion_r127447190
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
    @@ -1436,7 +1436,7 @@ public String create(final String path, byte data[], List<ACL>
acl,
             request.setData(data);
             request.setFlags(createMode.toFlag());
             request.setPath(serverPath);
    -        if (acl != null && acl.size() == 0) {
    +        if (acl == null || acl.isEmpty() || acl.contains(null)) {
    --- End diff --
    
    Throwing IllegalArgumentException is the correct way but it may break the existing behavior.
Consider the case where application code is like 
    
               zk.create(callBackHandler)` // call to create api and callback handler is passed
               doSomething();
               - - - -  // some more stuff
    
    At present, if client pass null ACL parameter, the error will be handled by callBackHandler
and in application code doSomething() method will execute. 
    
    But if we throw IllegalArgumentException , then doSomething() method will not execute.
So it will change the existing behavior of application code. 
    
    Please suggest if we really need to handle this case. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message