zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log
Date Thu, 13 Jul 2017 03:26:33 GMT
Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/307#discussion_r127116226
  
    --- Diff: src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
    @@ -430,6 +432,7 @@ public void processRequest(Request request) {
                 // the client and leader disagree on where the client is most
                 // recently attached (and therefore invalid SESSION MOVED generated)
                 cnxn.sendCloseSession();
    +            request.checkLatency();
    --- End diff --
    
    I see that both `request.checkLatency()` and  `zks.serverStats().updateLatency(request.createTime);`
(a few lines above) are dealing with the same matter (request latency) even though on radical
different positions.
    
    IMHO, `zks.serverStats().updateLatency(request.createTime);` should be moved to the line
position where `request.checkLatency()` currently is and to move the if condition from `request.checkLatency()`
to `zks.serverStats().updateLatency(request.createTime);`, eventually getting rid of `request.checkLatency()`.
Could this raise some unexpected bugs?
    
    @karanmehta93 @hanm, wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message