zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karanmehta93 <...@git.apache.org>
Subject [GitHub] zookeeper pull request #307: ZOOKEEPER-2770 ZooKeeper slow operation log
Date Wed, 12 Jul 2017 19:25:01 GMT
Github user karanmehta93 commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
    @@ -292,6 +293,8 @@ public void parseProperties(Properties zkProp)
                 } else if ((key.startsWith("server.") || key.startsWith("group") || key.startsWith("weight"))
&& zkProp.containsKey("dynamicConfigFile")) {
                     throw new ConfigException("parameter: " + key + " must be in a separate
dynamic config file");
    +            } else if(key.equals("warn.responseTime")) {
    --- End diff --
    I will document the new property and change the name to the suggested one.
    I have tested this feature manually. 
    I am currently trying to add unit test case in NettyServerCnxnTest.java or NIOServerCnxnTest.java,
but seems too high level approach.
    Can you suggest any locations for adding test case? @hanm 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message