zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #306: ZOOKEEPER-2841: ZooKeeper public include files leak po...
Date Tue, 11 Jul 2017 04:10:48 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/306
  
    @andschwa 
    Patch looks good to me. The readme update looks good too. 
    
    I also verified Linux and Mac c client builds with the patch. Unfortunately I don't have
a windows box to test. Can you please describe what kinds of test / integration test you did
on windows? 
    
    There are two remaining issues:
    * Can you please update the pull request description by adding a brief description on
what this patch is for and how it did it. The pull request description will be part of commit
message, and it's good to have a informative commit message.
    
    * This pull request is targeting master, which is not going to be released soon. branch-3.5
and branch-3.4 are branches for next releases, are you going to send separate pull requests
to those branches, or you are fine just with this merged into master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message