zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arshadmohammad <...@git.apache.org>
Subject [GitHub] zookeeper pull request #279: ZOOKEEPER-2804:Node creation fails with NPE if ...
Date Mon, 10 Jul 2017 17:07:01 GMT
Github user arshadmohammad commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/279#discussion_r126481060
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
    @@ -1436,7 +1436,7 @@ public String create(final String path, byte data[], List<ACL>
acl,
             request.setData(data);
             request.setFlags(createMode.toFlag());
             request.setPath(serverPath);
    -        if (acl != null && acl.size() == 0) {
    +        if (acl == null || acl.isEmpty() || acl.contains(null)) {
    --- End diff --
    
    These validations should also be applied on async create APIs 
    
    1. org.apache.zookeeper.ZooKeeper.create(String, byte[], List<ACL>, CreateMode,
Create2Callback, Object, long) 
    2. org.apache.zookeeper.ZooKeeper.create(String, byte[], List<ACL>, CreateMode,
StringCallback, Object)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message