zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #306: ZOOKEEPER-2841: ZooKeeper public include files leak po...
Date Sat, 08 Jul 2017 22:11:08 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/306
  
    Should we put the CMake files in a dedicated folder called "windows" or something like
that? Otherwise we will have the CMakeList file, and the existing makefile and config files
(which are not touched by this pull request) coexisting under the C client folder. This might
create confusions for user because makefile can be generated from the CMakeList file, so the
question of which makefile is the source of truth and so on... 
    
    Ultimately we might drop existing makefiles in favor of the CMake so build files across
every platform are generated by a single source of truth (cmakelist), but that's more scope
of work (the ant build file has to be modified and the system requirements of ZK has to be
updated to make cmake a dependency for source installations etc to avoid break existing workflows),
so for now I think it's good to scope cmake so it only impact windows C client builds.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message