zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #306: ZOOKEEPER-2841: ZooKeeper public include files ...
Date Sat, 08 Jul 2017 21:50:25 GMT
Github user hanm commented on a diff in the pull request:

    --- Diff: src/c/CMakeLists.txt ---
    @@ -0,0 +1,220 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +cmake_minimum_required(VERSION 3.6)
    +project(zookeeper VERSION 3.5.2)
    --- End diff --
    The version here should be 3.5.3. I think you got 3.5.2 because when you start working
on this, 3.5.3 was not released. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message