zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jainbhupendra24 <...@git.apache.org>
Subject [GitHub] zookeeper pull request #:
Date Thu, 06 Jul 2017 09:25:45 GMT
Github user jainbhupendra24 commented on the pull request:

    https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22946367
  
    In src/java/test/org/apache/zookeeper/test/ACLTest.java:
    In src/java/test/org/apache/zookeeper/test/ACLTest.java on line 197:
    If these lines are put in a private method then the variables (zks, f and zk ) which are
required further in finally block will not be available for use and code gets complicated.
 
    Also I checked the similar duplication is present in many other tests also.  May be we
can do this duplication cleanup by some other JIRA if needed .   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message