Return-Path: <dev-return-61433-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id CCC37200CC3
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Sat,  1 Jul 2017 00:22:43 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id CB6F7160BF6; Fri, 30 Jun 2017 22:22:43 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 1DFF2160BEB
	for <archive-asf-public@cust-asf.ponee.io>; Sat,  1 Jul 2017 00:22:42 +0200 (CEST)
Received: (qmail 94847 invoked by uid 500); 30 Jun 2017 22:22:42 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 94835 invoked by uid 99); 30 Jun 2017 22:22:41 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jun 2017 22:22:41 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D6497DFA84; Fri, 30 Jun 2017 22:22:41 +0000 (UTC)
From: hanm <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-291-zookeeper@git.apache.org>
In-Reply-To: <git-pr-291-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #291: ZOOKEEPER-2818. Improve the ZooKeeper#setACL ja...
Content-Type: text/plain
Message-Id: <20170630222241.D6497DFA84@git1-us-west.apache.org>
Date: Fri, 30 Jun 2017 22:22:41 +0000 (UTC)
archived-at: Fri, 30 Jun 2017 22:22:44 -0000

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/291#discussion_r125140546
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
    @@ -2347,25 +2347,25 @@ public void getACL(final String path, Stat stat, ACLCallback cb,
     
         /**
          * Set the ACL for the node of the given path if such a node exists and the
    -     * given version matches the version of the node. Return the stat of the
    +     * given aclVersion matches the aclVersion of the node. Return the stat of the
          * node.
          * <p>
          * A KeeperException with error code KeeperException.NoNode will be thrown
          * if no node with the given path exists.
          * <p>
          * A KeeperException with error code KeeperException.BadVersion will be
    -     * thrown if the given version does not match the node's version.
    +     * thrown if the given aclVersion does not match the node's aclVersion.
          *
          * @param path
          * @param acl
    -     * @param version
    +     * @param aclVersion
    --- End diff --
    
    Thanks for updating. Yes no need patch every parameter in this patch. 
    
    >> given aclVersion matches the aclVersion of the node.
    
    How about this: `given aclVersion matches the acl version of the node`. Similarly for the param:
    
    >> aclVersion the given aclVersion for the node
    
    `aclVersion - the given acl version of the node`.
    
    Copy pasting does not make it more descriptive, thus my suggestion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---