Return-Path: <dev-return-60841-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 80D64200CA6
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 13 Jun 2017 14:12:46 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 7F2AD160BDC; Tue, 13 Jun 2017 12:12:46 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id BC3F7160BC9
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 13 Jun 2017 14:12:45 +0200 (CEST)
Received: (qmail 75029 invoked by uid 500); 13 Jun 2017 12:12:44 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 75018 invoked by uid 99); 13 Jun 2017 12:12:44 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jun 2017 12:12:44 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1E517DFAF1; Tue, 13 Jun 2017 12:12:42 +0000 (UTC)
From: jainbhupendra24 <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-279-zookeeper@git.apache.org>
In-Reply-To: <git-pr-279-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #279: ZOOKEEPER-2804:Node creation fails with NPE if ...
Content-Type: text/plain
Message-Id: <20170613121243.1E517DFAF1@git1-us-west.apache.org>
Date: Tue, 13 Jun 2017 12:12:42 +0000 (UTC)
archived-at: Tue, 13 Jun 2017 12:12:46 -0000

Github user jainbhupendra24 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/279#discussion_r121657958
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
    @@ -1436,7 +1436,7 @@ public String create(final String path, byte data[], List<ACL> acl,
             request.setData(data);
             request.setFlags(createMode.toFlag());
             request.setPath(serverPath);
    -        if (acl != null && acl.size() == 0) {
    +        if (acl == null || acl.size() == 0) {
    --- End diff --
    
    This client side nulll check is better to add. I will add


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---