Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: maoling <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-262-zookeeper@git.apache.org>
In-Reply-To: <git-pr-262-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper issue #262: ZOOKEEPER-2789: Reassign `ZXID` for solving 32bit over...
Content-Type: text/plain
Message-Id: <20170605104720.DE3CEDFBC6@git1-us-west.apache.org>
Date: Mon,  5 Jun 2017 10:47:20 +0000 (UTC)
archived-at: Mon, 05 Jun 2017 10:47:23 -0000

Github user maoling commented on the issue:

    https://github.com/apache/zookeeper/pull/262
  
    Hi, @asdf2014 .Thanks for your explanation! But I still have some confusions about the question one:
    look at code like this :
    ```
    int epoch = (int)Long.rotateRight(zxid, 32);// >> 32;
    long count = zxid & 0xffffffffffL;
    ```
    it all depends on that **zxid** can not be altered(no write operation when **zxid** has generated at the first time) in the multithread situation,otherwise epoch and count isn't idempotent.should **zxid** be decorated by **final**?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---