zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #286: ZOOKEEPER-2786: Flaky test: org.apache.zookeepe...
Date Mon, 19 Jun 2017 20:20:54 GMT
GitHub user afine opened a pull request:

    https://github.com/apache/zookeeper/pull/286

    ZOOKEEPER-2786: Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

    As @hanm noticed and mentioned on the JIRA this flaky test can still fail. The reason
is that we can reconnect before calling `watcher.waitForDisconnected(5000);` We need to make
sure that we only process a single event from the watcher. Using a `synchronized (watcher)`
provides that guarantee here. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2786_3.5_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #286
    
----
commit 0c2bd6455eeab14a4f57499f0f3f6dda52fea1c0
Author: Abraham Fine <afine@apache.org>
Date:   2017-06-19T20:17:11Z

    ZOOKEEPER-2786: Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message