zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jainbhupendra24 <...@git.apache.org>
Subject [GitHub] zookeeper pull request #279: ZOOKEEPER-2804:Node creation fails with NPE if ...
Date Sat, 10 Jun 2017 20:27:37 GMT
GitHub user jainbhupendra24 opened a pull request:

    https://github.com/apache/zookeeper/pull/279

    ZOOKEEPER-2804:Node creation fails with NPE if ACLs are null

    1) Handled Null case in server. Client will get InvalidACLException 
    2) Handled null check in create and setACL APIs in client side. as per their javadoc 
    @throws KeeperException.InvalidACLException if the ACL is invalid, null, or empty
    3) Not handling any validation for async API of create and setACL in this JIRA because
these API doesn't throw KeeperException explicitly. So can not throw InvalidACLException from
Client.  If we throw IllegalArgumentException then it will not be consistent with other sync
APIs.  So Let server throw InvalidACLException for async API.
    
    
    Please review and provide suggestion. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jainbhupendra24/zookeeper ZOOKEEPER-2804-new

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #279
    
----
commit 9deacdabc061b95b24242a6bc557b7ee031bdf9e
Author: bhupendra jain <bhupendra.jain@huawei.com>
Date:   2017-06-10T20:16:44Z

    ZOOKEEPER-2804:Node creation fails with NPE if ACLs are null

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message