zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2827) Code refactoring for `JUTE` module
Date Thu, 29 Jun 2017 05:25:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067759#comment-16067759
] 

Hadoop QA commented on ZOOKEEPER-2827:
--------------------------------------

+1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/840//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/840//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/840//console

This message is automatically generated.

> Code refactoring for `JUTE` module
> ----------------------------------
>
>                 Key: ZOOKEEPER-2827
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2827
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: jute
>    Affects Versions: 3.5.3
>            Reporter: Benedict Jin
>            Assignee: Benedict Jin
>             Fix For: 3.5.4, 3.6.0
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> * Fix spell issues
> * Simplify `return` clause
> * Using enhanced `for` loop
> * Using `try` clause to release the resource of stream
> * Remove unnecessary `new Class[]{...}` boxing
> * Remove unnecessary `return` clause
> * Remove unnecessary `import`



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message