zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2826) Code refactoring for `CLI` module
Date Thu, 29 Jun 2017 02:28:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067601#comment-16067601
] 

ASF GitHub Bot commented on ZOOKEEPER-2826:
-------------------------------------------

GitHub user asdf2014 opened a pull request:

    https://github.com/apache/zookeeper/pull/298

    ZOOKEEPER-2826: Code refactoring for `CLI` module

    * Fix spell issues
    * Remove unnecessary `import`
    * Make initialization block that related with `options.addOption` into static
    * Standardize `StringBuilder#append` usage
    * Using `try` clause to release the resource of stream

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/asdf2014/zookeeper ZOOKEEPER-2826

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #298
    
----
commit 18cf0ab2c6fd33a77d46183c289f1b385acdf873
Author: asdf2014 <1571805553@qq.com>
Date:   2017-06-29T01:59:59Z

    Code refactoring for `CLI` module

----


> Code refactoring for `CLI` module
> ---------------------------------
>
>                 Key: ZOOKEEPER-2826
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2826
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.5.3
>            Reporter: Benedict Jin
>            Assignee: Benedict Jin
>             Fix For: 3.5.4, 3.6.0
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> * Fix spell issues
> * Remove unnecessary `import`
> * Make initialization block that related with `options.addOption` into static
> * Standardize `StringBuilder#append` usage
> * Using `try` clause to release the resource of stream



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message