zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2819) Changing membership configuration via rolling restart does not work on 3.5.x.
Date Fri, 30 Jun 2017 21:10:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070728#comment-16070728
] 

ASF GitHub Bot commented on ZOOKEEPER-2819:
-------------------------------------------

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/292#discussion_r125130820
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java ---
    @@ -28,9 +28,15 @@
     import org.apache.zookeeper.test.ClientBase;
     import org.apache.zookeeper.test.ReconfigTest;
     import org.junit.Assert;
    +import org.junit.Before;
     import org.junit.Test;
     
     public class ReconfigRecoveryTest extends QuorumPeerTestBase {
    +    @Before
    +    public void setup() {
    +        QuorumPeerConfig.setReconfigEnabled(true);
    --- End diff --
    
    Yes if those tests require reconfig feature being enabled. I think I've patched all reconfig
test in ZOOKEEPER-2014, and the modifications of related tests here are all about refactoring
and consolidating setting of the flag in a single place.


> Changing membership configuration via rolling restart does not work on 3.5.x.
> -----------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2819
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2819
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum, server
>    Affects Versions: 3.5.0, 3.5.1, 3.5.2, 3.5.3
>            Reporter: Michael Han
>            Assignee: Michael Han
>            Priority: Critical
>
> In 3.5.x there is no easy way of changing the membership config using rolling restarts
because of the introduction of dynamic reconfig feature in ZOOKEEPER-107, which automatically
manages membership configuration parameters.
> ZOOKEEPER-2014 introduced a reconfigEnabled flag to turn on / off the reconfig feature.
We can use same flag and when it sets to false, it should disable both in memory and on disk
updates of membership configuration information, besides disabling the reconfig commands on
CLI which ZOOKEEPER-2014 already did, so users can continue using rolling restarts if needed.

> We should also document explicitly the support of membership changes via rolling restarts
will be deprecated at what release time frame and promote reconfig as the replacement.
> The problem was raised at user mailing list by Guillermo Vega-Toro, reference thread:
> http://zookeeper-user.578899.n2.nabble.com/How-to-add-nodes-to-a-Zookeeper-3-5-3-beta-ensemble-with-reconfigEnabled-false-td7583138.html



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message