zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2803) Flaky test: org.apache.zookeeper.test.CnxManagerTest.testWorkerThreads
Date Thu, 08 Jun 2017 22:24:18 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043538#comment-16043538
] 

ASF GitHub Bot commented on ZOOKEEPER-2803:
-------------------------------------------

GitHub user afine opened a pull request:

    https://github.com/apache/zookeeper/pull/277

    ZOOKEEPER-2803 Flaky test: org.apache.zookeeper.test.CnxManagerTest.testWorkerThreads

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2803

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #277
    
----
commit 0a6ada6ba25ab3d4b2094a4c5f1842a9a0b67dfc
Author: Abraham Fine <abefine@cloudera.com>
Date:   2017-06-08T22:10:41Z

    ZOOKEEPER-2803: Flaky test: org.apache.zookeeper.test.CnxManagerTest.testWorkerThreads

----


> Flaky test: org.apache.zookeeper.test.CnxManagerTest.testWorkerThreads
> ----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2803
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2803
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.10
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>
> We have noticed on internal executions of the integration tests rare failures of org.apache.zookeeper.test.CnxManagerTest.testWorkerThreads.
> {code}
> java.lang.RuntimeException: Unable to run quorum server 
> 	at org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:565)
> 	at org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:520)
> 	at org.apache.zookeeper.test.CnxManagerTest.testWorkerThreads(CnxManagerTest.java:328)
> 	at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> Caused by: java.io.IOException: The current epoch, 0, is older than the last zxid, 4294967296
> 	at org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:546)
> {code}
> along with this strange stack trace in the logs:
> {code}
> java.nio.channels.ClosedByInterruptException
> 	at java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:202)
> 	at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:380)
> 	at org.apache.zookeeper.common.AtomicFileOutputStream.close(AtomicFileOutputStream.java:71)
> 	at org.apache.zookeeper.server.quorum.QuorumPeer.writeLongToFile(QuorumPeer.java:1232)
> 	at org.apache.zookeeper.server.quorum.QuorumPeer.setCurrentEpoch(QuorumPeer.java:1253)
> 	at org.apache.zookeeper.server.quorum.Learner.syncWithLeader(Learner.java:412)
> 	at org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:83)
> 	at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:851)
> {code}
> It appears that this failure is related to the usage of {{((FileOutputStream) out).getChannel().force(true)}}
in {{AtomicFileOutputStream}}. {{FileChannel#force}} appears to be interruptible, which is
not desirable behavior when writing the epoch file. The interrupt may be triggered by the
repeated starting and shutting down of quorum peers in {{testWorkerThreads}}. Branch 3.5 uses
{{FileDescriptor#sync}} which is not interruptible and does not appear to have the same problem.
> I was able to find another JIRA ticket describing a similar issue here: https://issues.apache.org/jira/browse/DERBY-4963
> There is also interesting discussion in ZOOKEEPER-1835 (where the change was made for
3.5) although these discussions appear to be Windows centric (we noticed the issue on Linux)
https://issues.apache.org/jira/browse/ZOOKEEPER-1835 
> {{testWorkerThreads}} appears to be failing every few months on Solaris on Apache Jenkins
(for 3.4 and 3.5), but at the time I wrote this Jenkins had cleaned out the logs from the
latest failed run so I have no way of determining if the cause is the same.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message