zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2801) address spelling errors/typos
Date Tue, 06 Jun 2017 19:24:18 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039504#comment-16039504
] 

ASF GitHub Bot commented on ZOOKEEPER-2801:
-------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/275#discussion_r120455520
  
    --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java ---
    @@ -94,7 +94,7 @@ synchronized void removeWatcher(Watcher watcher) {
             return triggerWatch(path, type, null);
         }
     
    -    Set<Watcher> triggerWatch(String path, EventType type, Set<Watcher> supress)
{
    +    Set<Watcher> triggerWatch(String path, EventType type, Set<Watcher> suppress)
{
    --- End diff --
    
    I think we should avoid code changes here. 


> address spelling errors/typos
> -----------------------------
>
>                 Key: ZOOKEEPER-2801
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2801
>             Project: ZooKeeper
>          Issue Type: Improvement
>    Affects Versions: 3.5.3
>            Reporter: tony mancill
>            Assignee: tony mancill
>            Priority: Trivial
>
> This is a follow-on for ZOOKEEPER-2617 (for which I only supplied a patch for branch-3.4),
that addresses minor typos in master.  With a slight modification, the patch also applies
against the branch-3.5 branch.
> If folks are curious, the typos are spotted with the "spellintian" shipped with Debian's
lintian package.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message