zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2786) Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode
Date Mon, 19 Jun 2017 20:21:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054675#comment-16054675

ASF GitHub Bot commented on ZOOKEEPER-2786:

GitHub user afine opened a pull request:


    ZOOKEEPER-2786: Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode

    As @hanm noticed and mentioned on the JIRA this flaky test can still fail. The reason
is that we can reconnect before calling `watcher.waitForDisconnected(5000);` We need to make
sure that we only process a single event from the watcher. Using a `synchronized (watcher)`
provides that guarantee here. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2786_3.5_fix

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #286
commit 0c2bd6455eeab14a4f57499f0f3f6dda52fea1c0
Author: Abraham Fine <afine@apache.org>
Date:   2017-06-19T20:17:11Z

    ZOOKEEPER-2786: Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode


> Flaky test: org.apache.zookeeper.test.ClientTest.testNonExistingOpCode
> ----------------------------------------------------------------------
>                 Key: ZOOKEEPER-2786
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2786
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.10, 3.5.3
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>             Fix For: 3.5.4, 3.6.0, 3.4.11
> This test is broken on 3.4 and 3.5, but is broken in "different" ways. Please see the
individual pull requests for detailed descriptions for the issues faced in both branches.

This message was sent by Atlassian JIRA

View raw message