zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1782) zookeeper.superUser is not as super as superDigest
Date Mon, 19 Jun 2017 12:59:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053940#comment-16053940
] 

ASF GitHub Bot commented on ZOOKEEPER-1782:
-------------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/282#discussion_r122698936
  
    --- Diff: src/java/main/org/apache/zookeeper/server/auth/SASLAuthenticationProvider.java
---
    @@ -38,11 +38,6 @@ public String getScheme() {
         }
     
         public boolean matches(String id,String aclExpr) {
    -        if (System.getProperty("zookeeper.superUser") != null) {
    -            if (id.equals(System.getProperty("zookeeper.superUser")) || id.equals(aclExpr))
{
    -              return true;
    -            }
    -        }
             if ((id.equals("super") || id.equals(aclExpr))) {
    --- End diff --
    
    Sure.  It looks like I am going to have to pull out the "super" user SASL Login too.
    
    https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java#L42
    https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java#L99-L101
    
    Do you know where the source for the documentation at https://zookeeper.apache.org/doc/r3.3.3/zookeeperAdmin.html
is? Under the section "Authentication & Authorization Options" it talks about how to use
the "super" user. 
    
    I also found docs for this in a few other places on the open internet and because this
is a backwards incompatible change I get a little nervous, so is there anything else I need
to do to document a breaking change like this?



> zookeeper.superUser is not as super as superDigest
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-1782
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1782
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.5
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: zk-1782.patch, zk-1782.patch
>
>
> The zookeeper.superUser system property does not fully grant super user privileges, like
zookeeper.DigestAuthenticationProvider.superDigest does.
> zookeeper.superUser only has as many privileges as the sasl ACLs on the znode being accessed.
 This means that if a znode only has digest ACLs zookeeper.superUser is ignored.  Or if a
znode has a single sasl ACL that only has read privileges zookeeper.superUser only has read
privileges.
> The reason for this is that SASLAuthenticationProvider implements the superUser check
in the matches method, instead of having the super user include a new Id("super","") as Digest
does.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message