zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1782) zookeeper.superUser is not as super as superDigest
Date Sun, 18 Jun 2017 09:33:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053137#comment-16053137
] 

ASF GitHub Bot commented on ZOOKEEPER-1782:
-------------------------------------------

Github user arshadmohammad commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/282#discussion_r122586398
  
    --- Diff: src/java/test/org/apache/zookeeper/test/SaslSuperUserTest.java ---
    @@ -0,0 +1,118 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.test;
    +
    +import java.io.File;
    +import java.io.FileWriter;
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.List;
    +import java.util.concurrent.atomic.AtomicInteger;
    +
    +import org.apache.zookeeper.CreateMode;
    +import org.apache.zookeeper.KeeperException;
    +import org.apache.zookeeper.TestableZooKeeper;
    +import org.apache.zookeeper.WatchedEvent;
    +import org.apache.zookeeper.ZooKeeper;
    +import org.apache.zookeeper.Watcher.Event.KeeperState;
    +import org.apache.zookeeper.ZooDefs.Ids;
    --- End diff --
    
    The import org.apache.zookeeper.ZooDefs.Ids is never used.
    There are many other unused imports as well



> zookeeper.superUser is not as super as superDigest
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-1782
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1782
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.5
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: zk-1782.patch, zk-1782.patch
>
>
> The zookeeper.superUser system property does not fully grant super user privileges, like
zookeeper.DigestAuthenticationProvider.superDigest does.
> zookeeper.superUser only has as many privileges as the sasl ACLs on the znode being accessed.
 This means that if a znode only has digest ACLs zookeeper.superUser is ignored.  Or if a
znode has a single sasl ACL that only has read privileges zookeeper.superUser only has read
privileges.
> The reason for this is that SASLAuthenticationProvider implements the superUser check
in the matches method, instead of having the super user include a new Id("super","") as Digest
does.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message