zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shralex <...@git.apache.org>
Subject [GitHub] zookeeper pull request #292: ZOOKEEPER-2819:Changing membership configuratio...
Date Fri, 30 Jun 2017 20:51:35 GMT
Github user shralex commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/292#discussion_r125121157
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java ---
    @@ -89,6 +89,7 @@ public void tearDown() throws Exception {
     
         @Test(timeout = 10000)
         public void testReconfigDisabledByDefault() throws InterruptedException {
    +        QuorumPeerConfig.setReconfigEnabled(false);
    --- End diff --
    
    Given that the test is called "disabled-by-default" Its strange to disable this manually
here. I suggest to rename the test to reflect what its doing - checking that when the flag
is false reconfig ops aren't allowed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message