zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #293: ZOOKEEPER-2821: 1. Fix spell issues; 2. Remove ...
Date Thu, 29 Jun 2017 20:18:40 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/293#discussion_r124902518
  
    --- Diff: src/java/main/org/apache/zookeeper/server/auth/SASLAuthenticationProvider.java
---
    @@ -28,24 +28,20 @@ public String getScheme() {
         }
     
         public KeeperException.Code
    -        handleAuthentication(ServerCnxn cnxn, byte[] authData)
    -    {
    +        handleAuthentication(ServerCnxn cnxn, byte[] authData) {
             // Should never call this: SASL authentication is negotiated at session initiation.
             // TODO: consider substituting current implementation of direct ClientCnxn manipulation
with
             // a call to this method (SASLAuthenticationProvider:handleAuthentication())
at session initiation.
             return KeeperException.Code.AUTHFAILED;
     
         }
     
    -    public boolean matches(String id,String aclExpr) {
    -        if ((id.equals("super") || id.equals(aclExpr))) {
    --- End diff --
    
    why was this change necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message