zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shralex <...@git.apache.org>
Subject [GitHub] zookeeper pull request #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2...
Date Thu, 29 Jun 2017 04:29:01 GMT
Github user shralex commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/297#discussion_r124709964
  
    --- Diff: src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java ---
    @@ -590,14 +590,13 @@ public boolean clientTunneledAuthenticationInProgress() {
                     // authentication is either in progress, successful, or failed.
     
                     // 1. Authentication hasn't finished yet: we must wait for it to do so.
    -                if ((isComplete() == false) &&
    -                    (isFailed() == false)) {
    +                if ((!isComplete()) && (!isFailed())) {
                         return true;
                     }
     
                     // 2. SASL authentication has succeeded or failed..
                     if (isComplete() || isFailed()) {
    --- End diff --
    
    wouldn't this always be true because of the previous if condition ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message