zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #292: ZOOKEEPER-2819:Changing membership configuration via r...
Date Tue, 27 Jun 2017 21:17:27 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/292
  
    Thanks for review, @shralex @asdf2014 . Code updated. 
    
    I also refactored a couple of reconfig tests to consolidate the setting of the feature
flag, which makes the test both easier to read and also fix potential race conditions I found
out while working on this patch: because the flag was set in a different thread while the
peers are running, it is possible the peer thread still cache old value. Such case would not
happen for real use case (aside from artificial tests we created here) because the feature
flag will not change after ensemble is started. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message