zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #292: ZOOKEEPER-2819:Changing membership configuratio...
Date Tue, 27 Jun 2017 21:11:26 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/292#discussion_r124396899
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -1744,9 +1744,14 @@ public void setAcceptedEpoch(long e) throws IOException {
         public boolean processReconfig(QuorumVerifier qv, Long suggestedLeaderId, Long zxid,
boolean restartLE) {
            InetSocketAddress oldClientAddr = getClientAddress();
     
    +       boolean isReconfigEnabled = QuorumPeerConfig.isReconfigEnabled();
            // update last committed quorum verifier, write the new config to disk
    -       // and restart leader election if config changed
    -       QuorumVerifier prevQV = setQuorumVerifier(qv, true);
    +       // and restart leader election if config changed. If reconfig feature is
    +       // not enabled, just set last committed quorum verifier and bail out.
    +       QuorumVerifier prevQV = setQuorumVerifier(qv, isReconfigEnabled);
    --- End diff --
    
    Updated. Now I am returning immediately at the start of processReconfig if the feature
flag is not set. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message