zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brahmareddybattula <...@git.apache.org>
Subject [GitHub] zookeeper pull request #291: ZOOKEEPER-2818. Improve the ZooKeeper#setACL ja...
Date Mon, 26 Jun 2017 01:10:46 GMT
Github user brahmareddybattula commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/291#discussion_r123914814
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
    @@ -2347,25 +2347,25 @@ public void getACL(final String path, Stat stat, ACLCallback cb,
     
         /**
          * Set the ACL for the node of the given path if such a node exists and the
    -     * given version matches the version of the node. Return the stat of the
    +     * given aclVersion matches the aclVersion of the node. Return the stat of the
          * node.
          * <p>
          * A KeeperException with error code KeeperException.NoNode will be thrown
          * if no node with the given path exists.
          * <p>
          * A KeeperException with error code KeeperException.BadVersion will be
    -     * thrown if the given version does not match the node's version.
    +     * thrown if the given aclVersion does not match the node's aclVersion.
          *
          * @param path
          * @param acl
    -     * @param version
    +     * @param aclVersion
    --- End diff --
    
    In that case dn't we need to consider remain two args(path,acl) also..? if you agree,
might be handle in another jira..?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message