zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arshadmohammad <...@git.apache.org>
Subject [GitHub] zookeeper pull request #282: ZOOKEEPER-1782: Let a SASL super user be super
Date Wed, 21 Jun 2017 18:27:17 GMT
Github user arshadmohammad commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/server/auth/SASLAuthenticationProvider.java
    @@ -38,11 +38,6 @@ public String getScheme() {
         public boolean matches(String id,String aclExpr) {
    -        if (System.getProperty("zookeeper.superUser") != null) {
    -            if (id.equals(System.getProperty("zookeeper.superUser")) || id.equals(aclExpr))
    -              return true;
    -            }
    -        }
             if ((id.equals("super") || id.equals(aclExpr))) {
    --- End diff --
    Thanks @revans2 for the details.
    On second thought, it would not be appropriate to break the backward compatibility. So
can you please revert changes done for this comment. Rest all looks good to me.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message