zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jainbhupendra24 <...@git.apache.org>
Subject [GitHub] zookeeper pull request #279: ZOOKEEPER-2804:Node creation fails with NPE if ...
Date Tue, 13 Jun 2017 12:12:42 GMT
Github user jainbhupendra24 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/279#discussion_r121657958
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
    @@ -1436,7 +1436,7 @@ public String create(final String path, byte data[], List<ACL>
acl,
             request.setData(data);
             request.setFlags(createMode.toFlag());
             request.setPath(serverPath);
    -        if (acl != null && acl.size() == 0) {
    +        if (acl == null || acl.size() == 0) {
    --- End diff --
    
    This client side nulll check is better to add. I will add


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message